Open
Conversation
Contributor
|
@ojab can you please rebase your branch on master ? |
Author
|
Sure, done. |
Alexander-Senko
force-pushed
the
patch-1
branch
from
d168f0f to
0bcc5b0
Compare
Alexander-Senko
changed the title
Alexander-Senko
requested changes
Aug 30, 2024
Collaborator
Alexander-Senko
left a comment
Alexander-Senko
left a comment
There was a problem hiding this comment.
Not sure if I should add test for that, since it's a workaround that can be dropped if/when rspec-mocks will be fixed.
I think we'd better have a test to check that nothing breaks when/if the workaround is removed.
Collaborator
|
I still can't get the rationale behind this PR, sorry. What scenario makes one to want this? expect(Draper::ViewContext.current).to receive(:render).and_call_originalI'm asking because the scenario or the expectation themselves could be worked around instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now it's not possible to do something like
expect(Draper::ViewContext.current).to receive(:render).and_call_originalsince it fails, workaround it.Testing
Not sure if I should add test for that, since it's a workaround that can be dropped if/when rspec-mocks will be fixed.
To-Dos
References
self.class.define_method name && send(name)fails rspec/rspec#58